Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KERNEL: Optimize source code to build the kernel #5735

Merged
merged 1 commit into from
Aug 29, 2023
Merged

KERNEL: Optimize source code to build the kernel #5735

merged 1 commit into from
Aug 29, 2023

Conversation

ut003460
Copy link
Contributor

Omitted the requirement for multiprocessing. CPU_ Call count() and use None as the default value for njobs. We will check if njobs is a positive number, and if so, link the '- j' option with its value and add it to make_ Args list. Then, based on the binary_ Determine whether to add 'deb pkg' to make based on the conditions of package and distribution name_ Args list. Finally, we use spaces to make_ Connect the strings in the args list and call the build. make() function to perform the build operation

@mr-avocado
Copy link

mr-avocado bot commented Jul 19, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ut003460 thank you for your changes, the code LGTM. Can you please refactor your commit message to fulfill our commit styles (line length has to be 72 characters). Thank you.

Signed-off-by: ut003460 <[email protected]>

Omitted the requirement for multiprocessing. CPU_ Call count() and use None as the default value for njobs.
We will check if njobs is a positive number, and if so, link the '- j' option with its value and add it to
make_ Args list. Then, based on the binary_ Determine whether to add 'deb pkg' to make based on the conditions of
package and distribution name_ Args list. Finally, we use spaces to make_ Connect the strings in the args list and
call the build. make() function to perform the build operation
@ut003460 ut003460 closed this Aug 10, 2023
@ut003460 ut003460 reopened this Aug 10, 2023
@ut003460 ut003460 closed this Aug 11, 2023
@ut003460 ut003460 reopened this Aug 11, 2023
@ut003460 ut003460 requested a review from richtja August 14, 2023 05:35
Copy link
Member

@lmr lmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@richtja richtja merged commit a1cd8a8 into avocado-framework:master Aug 29, 2023
148 of 151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants